[PATCH v1] drm/i915: Fix TLB-Invalidation seqno store

Andi Shyti andi.shyti at linux.intel.com
Mon Aug 14 19:24:11 UTC 2023


Hi Alan,

On Mon, Aug 14, 2023 at 11:24:49AM -0700, Alan Previn wrote:
> When getting the next gt's seqno to be stored into an
> objects mm.tlb[gt_id] array, fix the retrieval code
> to get it from the correct gt instead of the same one.
> 
> Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT")
> Signed-off-by: Alan Previn <alan.previn.teres.alexis at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_vma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index e52089564d79..6f180ee13853 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -1356,7 +1356,7 @@ void vma_invalidate_tlb(struct i915_address_space *vm, u32 *tlb)
>  	 */
>  	for_each_gt(gt, vm->i915, id)
>  		WRITE_ONCE(tlb[id],
> -			   intel_gt_next_invalidate_tlb_full(vm->gt));
> +			   intel_gt_next_invalidate_tlb_full(gt));

ops!

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com> 

Thank you!
Andi


More information about the dri-devel mailing list