[PATCH -next] drm/amd/display: Simplify bool conversion

SHANMUGAM, SRINIVASAN SRINIVASAN.SHANMUGAM at amd.com
Wed Aug 16 15:57:45 UTC 2023


[AMD Official Use Only - General]

Thanks Li, for the fix, the fix is already in process of merging into amd-staging-drm-next.

https://patchwork.freedesktop.org/patch/552568/

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Yang Li
Sent: Wednesday, August 16, 2023 6:16 AM
To: airlied at gmail.com; daniel at ffwll.ch; Deucher, Alexander <Alexander.Deucher at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>
Cc: Yang Li <yang.lee at linux.alibaba.com>; dri-devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org; linux-kernel at vger.kernel.org
Subject: [PATCH -next] drm/amd/display: Simplify bool conversion

./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:94:102-107: WARNING: conversion to bool not needed here
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:102:72-77: WARNING: conversion to bool not needed here

Signed-off-by: Yang Li <yang.lee at linux.alibaba.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
index 32d3086c4cb7..5ce542b1f860 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
@@ -91,7 +91,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac
        pr_config.replay_supported = true;
        pr_config.replay_power_opt_supported = 0;
        pr_config.replay_enable_option |= pr_enable_option_static_screen;
-       pr_config.replay_timing_sync_supported = aconnector->max_vfreq >= 2 * aconnector->min_vfreq ? true : false;
+       pr_config.replay_timing_sync_supported = aconnector->max_vfreq >= 2 *
+aconnector->min_vfreq;

        if (!pr_config.replay_timing_sync_supported)
                pr_config.replay_enable_option &= ~pr_enable_option_general_ui; @@ -99,7 +99,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac
        debug_flags = (union replay_debug_flags *)&pr_config.debug_flags;
        debug_flags->u32All = 0;
        debug_flags->bitfields.visual_confirm =
-               link->ctx->dc->debug.visual_confirm == VISUAL_CONFIRM_REPLAY ? true : false;
+               link->ctx->dc->debug.visual_confirm == VISUAL_CONFIRM_REPLAY;

        link->replay_settings.replay_feature_enabled = true;

--
2.20.1.7.g153144c



More information about the dri-devel mailing list