[PATCH] drm/scheduler: Partially revert "drm/scheduler: track GPU active time per entity"

[Chen, Guchun]

[Public]

Hi Xinhui,

That patch has been reverted on Linux mainline.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/scheduler/sched_main.c?h=v6.5-rc6&id=baad10973fdb442912af676de3348e80bd8fe602

Regards,
Guchun

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> xinhui pan
> Sent: Thursday, August 17, 2023 1:05 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Pan, Xinhui <Xinhui.Pan at amd.com>; dri-devel at lists.freedesktop.org;
> Tuikov, Luben <Luben.Tuikov at amd.com>; airlied at gmail.com; Koenig,
> Christian <Christian.Koenig at amd.com>; l.stach at pengutronix.de
> Subject: [PATCH] drm/scheduler: Partially revert "drm/scheduler: track GPU
> active time per entity"
>
> This patch partially revert commit df622729ddbf ("drm/scheduler: track GPU
> active time per entity") which touchs entity without any reference.
>
> I notice there is one memory overwritten from gpu scheduler side.
> The case is like below.
> A(drm_sched_main)                     B(vm fini)
> drm_sched_job_begin                   drm_sched_entity_kill
>       //job in pending_list                   wait_for_completion
> complete_all                          ...
> ...                                   kfree entity
> drm_sched_get_cleanup_job
>       //fetch job from pending_list
>       access job->entity //memory overwitten
>
> As long as we can NOT guarantee entity is alive in this case, lets revert it for
> now.
>
> Signed-off-by: xinhui pan <xinhui.pan at amd.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c
> b/drivers/gpu/drm/scheduler/sched_main.c
> index 602361c690c9..1b3f1a6a8514 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -907,12 +907,6 @@ drm_sched_get_cleanup_job(struct
> drm_gpu_scheduler *sched)
>
>       spin_unlock(&sched->job_list_lock);
>
> -     if (job) {
> -             job->entity->elapsed_ns += ktime_to_ns(
> -                     ktime_sub(job->s_fence->finished.timestamp,
> -                               job->s_fence->scheduled.timestamp));
> -     }
> -
>       return job;
>  }
>
> --
> 2.34.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 16266 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230817/30b3ee51/attachment-0001.bin>