[PATCH v3 2/3] dt-bindings: display: novatek,nt35950: define ports

Rob Herring robh at kernel.org
Wed Aug 23 09:08:37 UTC 2023


On Wed, 23 Aug 2023 10:14:59 +0200, Krzysztof Kozlowski wrote:
> The panel-common schema does not define what "ports" property is, so
> bring the definition by referencing the panel-common-dual.yaml. Panels
> can be single- or dual-link, thus require only one port at 0.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> 
> ---
> 
> Changes since v2:
> 1. Use panel-common-dual
> 
> Changes since v1:
> 1. Rework to add ports to device schema, not to panel-common.
> ---
>  .../devicetree/bindings/display/panel/novatek,nt35950.yaml     | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/display/panel/panel-common-dual.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/novatek,nt35950.example.dtb: panel at 0: False schema does not allow {'compatible': ['sharp,ls055d1sx04', 'novatek,nt35950'], 'reg': [[0]], 'backlight': [[4294967295]], 'reset-gpios': [[4294967295, 94, 0]], 'avdd-supply': [[4294967295]], 'avee-supply': [[4294967295]], 'dvdd-supply': [[4294967295]], 'vddio-supply': [[4294967295]], 'ports': {'#address-cells': [[1]], '#size-cells': [[0]], 'port at 0': {'reg': [[0]], 'endpoint': {'remote-endpoint': [[4294967295]]}}, 'port at 1': {'reg': [[1]], 'endpoint': {'remote-endpoint': [[4294967295]]}}}, '$nodename': ['panel at 0']}
	from schema $id: http://devicetree.org/schemas/display/panel/novatek,nt35950.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230823081500.84005-2-krzysztof.kozlowski@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



More information about the dri-devel mailing list