[PATCH AUTOSEL 5.15 6/6] drm/amdkfd: ignore crat by default

[Felix Kuehling]

On 2023-08-22 11:41, Deucher, Alexander wrote:
> [Public]
>
>> -----Original Message-----
>> From: Sasha Levin <sashal at kernel.org>
>> Sent: Tuesday, August 22, 2023 7:37 AM
>> To: linux-kernel at vger.kernel.org; stable at vger.kernel.org
>> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Kuehling, Felix
>> <Felix.Kuehling at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>;
>> Mike Lothian <mike at fireburn.co.uk>; Sasha Levin <sashal at kernel.org>; Pan,
>> Xinhui <Xinhui.Pan at amd.com>; airlied at gmail.com; daniel at ffwll.ch; amd-
>> gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
>> Subject: [PATCH AUTOSEL 5.15 6/6] drm/amdkfd: ignore crat by default
>>
>> From: Alex Deucher <alexander.deucher at amd.com>
>>
>> [ Upstream commit a6dea2d64ff92851e68cd4e20a35f6534286e016 ]
>>
>> We are dropping the IOMMUv2 path, so no need to enable this.
>> It's often buggy on consumer platforms anyway.
> This is not needed for stable.

I agree. I was about to comment in the 5.10 patch as well.

Regards,
   Felix


>
> Alex
>
>> Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>
>> Acked-by: Christian König <christian.koenig at amd.com>
>> Tested-by: Mike Lothian <mike at fireburn.co.uk>
>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>> Signed-off-by: Sasha Levin <sashal at kernel.org>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> index e574aa32a111d..46dfd9baeb013 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> @@ -1523,11 +1523,7 @@ static bool kfd_ignore_crat(void)
>>        if (ignore_crat)
>>                return true;
>>
>> -#ifndef KFD_SUPPORT_IOMMU_V2
>>        ret = true;
>> -#else
>> -     ret = false;
>> -#endif
>>
>>        return ret;
>>   }
>> --
>> 2.40.1