[PATCH] drm/panel/panel-sitronix-st7701: Move init sequence from prepare() to enable()

Marek Vasut marex at denx.de
Sat Aug 26 15:18:19 UTC 2023


On 8/26/23 11:55, Mimoja wrote:
> The struct drm_panel_funcs are offering a prepare() and an enable()
> entrypoint for panels. According to drm/panel.h:
> 
> "The .prepare() function is typically called before the display controller
> starts to transmit video data."
> and
> "After the display controller has started transmitting video data, it's safe
>   to call the .enable() function."
> 
> The st7701 driver currently does not respect this, queing DSI control commands
> during enable.

DSI commands are not DSI video, so this should be OK ?

> While generally fine this can lead to a fillup of the transmission queue before
> the transmission is set up on certain dsi bridges.
> This issue can also be seen on downstream imx8m* kernels.

Can you reproduce this with current mainline Linux or linux-next tree ?
I recall the display pipeline in the NXP downstream stuff is very 
different from mainline .

Which SoC does have this problem ?


More information about the dri-devel mailing list