[PATCH v2 5/9] accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init()

[Stanislaw Gruszka]

Hi

On Mon, Aug 28, 2023 at 02:49:34PM -0600, Jeffrey Hugo wrote:
> On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote:
> > diff --git a/drivers/accel/ivpu/ivpu_fw.h b/drivers/accel/ivpu/ivpu_fw.h
> > index 8567fdf925fe..10ae2847f0ef 100644
> > --- a/drivers/accel/ivpu/ivpu_fw.h
> > +++ b/drivers/accel/ivpu/ivpu_fw.h
> > @@ -31,7 +31,7 @@ struct ivpu_fw_info {
> >   int ivpu_fw_init(struct ivpu_device *vdev);
> >   void ivpu_fw_fini(struct ivpu_device *vdev);
> > -int ivpu_fw_load(struct ivpu_device *vdev);
> > +void ivpu_fw_load(struct ivpu_device *vdev);
> 
> If ivpu_fw_load() is defined in ivpu_fw.c and only used in ivpu_fw.c, do you
> need it in this header file anymore?  Seems like you could remove this, and
> also make the function static.

The function is also used in ivpu_pm_prepare_cold_boot() from ivpu_pm.c 

Regards
Stanislaw