[PATCH 17/17] drm/msm: drop mdp_get_formats()

[Abhinav Kumar]

On 12/1/2023 5:25 PM, Abhinav Kumar wrote:
> 
> 
> On 7/7/2023 6:04 PM, Dmitry Baryshkov wrote:
>> Drop the function mdp_get_formats(), which became unused after
>> converting both MDP4 and MDP5 planes to use static formats arrays.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> ---
>>   drivers/gpu/drm/msm/disp/mdp_format.c | 24 ------------------------
>>   drivers/gpu/drm/msm/disp/mdp_kms.h    |  1 -
>>   2 files changed, 25 deletions(-)
>>
> 
> Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

Actually, I have one concern with patch 1 and patch 17 of this series.

You cannot get rid of static const struct mdp_format formats[] because 
mdp_get_format() still uses it.

Now, we end up having to maintain two arrays to hold the formats, the 
already existing formats[] one and newly added  mdp_rgb_formats[] and 
mdp_rgb_yuv_formats[].

This is an overkill.

I am fine with overall migrating to drmm-managed APIs but I think patch 
1 and this one are not necessary.