[RFT PATCH v2 0/4] drm/msm/dpu: enable writeback on the other platforms

Abhinav Kumar quic_abhinavk at quicinc.com
Wed Dec 13 21:09:38 UTC 2023



On 12/11/2023 10:23 PM, Dmitry Baryshkov wrote:
> On Tue, 12 Dec 2023 at 02:30, Abhinav Kumar <quic_abhinavk at quicinc.com> wrote:
>>
>>
>>
>> On 12/2/2023 4:31 PM, Dmitry Baryshkov wrote:
>>> I was not able to test it on my own, this is a call for testing for the
>>> owners of these platforms. The git version of modetest now fully
>>> supports writeback.
>>>
>>> Use libdrm >= 2.4.117, run modetest -ac to determine the writeback
>>> connector, cat /sys/kernel/debug/dri/0/state to determine
>>> spare CRTC and plane, then run something like:
>>>
>>> modetest -M msm -a -s 36 at 85:1024x768 -o test.d -P 79 at 85:1024x768
>>>
>>> where 36 is the Writeback connector id, 85 is CRTC and 79 is the plane.
>>>
>>> Then press Enter and check the test.d file for the raw image dump.
>>>
>>> Changes since v1:
>>> - Fixed the DPU_CLK_CTRL_WB2 definition
>>>
>>
>> I think this series needs to be re-based as WB_SDM845_MASK is no longer
>> present in msm-next and 3/4 patches in this series use that.
> 
> Quite the contrary: the WB_SDM845_MASK was added in
> https://patchwork.freedesktop.org/patch/570189/?series=127245&rev=1,
> which is now merged to msm-next-lumag
> 

Ah okay, I was comparing against msm-next. Let me complete rest of the 
review checking the other branch.

>>
>>> Dmitry Baryshkov (4):
>>>     drm/msm/dpu: enable writeback on SM8150
>>>     drm/msm/dpu: enable writeback on SC8108X
>>>     drm/msm/dpu: enable writeback on SM6125
>>>     drm/msm/dpu: enable writeback on SM6350
>>>
>>>    .../drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 18 ++++++++++++++++++
>>>    .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h    | 18 ++++++++++++++++++
>>>    .../drm/msm/disp/dpu1/catalog/dpu_5_4_sm6125.h | 18 ++++++++++++++++++
>>>    .../drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 18 ++++++++++++++++++
>>>    4 files changed, 72 insertions(+)
>>>
> 
> 
> 


More information about the dri-devel mailing list