[PATCH v8 0/8] Improve test coverage of TTM

Christian König christian.koenig at amd.com
Thu Dec 14 10:22:29 UTC 2023



Am 14.12.23 um 09:20 schrieb Karolina Stolarek:
>
> Hi Christian,
>
> On 29.11.2023 13:02, Karolina Stolarek wrote:
>> Karolina Stolarek (8):
>>    drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man
>>    drm/ttm/tests: Add tests for ttm_tt
>>    drm/ttm/tests: Add tests for ttm_bo functions
> >    drm/ttm/tests: Fix argument in ttm_tt_kunit_init()
>
> Would it be possible to get these patches merged? They already have
> r-b's. There are a couple more, but these don't depend on any other
> patch that is pending review, and should be easy to get in.

Sure, just pushed those three to drm-misc-next.

>
> I'm asking for this because I have three final patches ready for
> submission (eviction, ttm_tt_populate, TODO file) and wondered if I
> should submit them as v9, or if I could create a new series. I'd prefer
> creating a new one, this patchset is already big and intimidating :)
> Having said that, thank you for taking your time to review the tests, I
> really appreciate it.

No problem, you are actually helping getting stuff from my way to long 
TODO list.

Regards,
Christian.

>
> All the best,
> Karolina
>
>>    drm/ttm/tests: Use an init function from the helpers lib
>>    drm/ttm/tests: Test simple BO creation and validation
>>    drm/ttm/tests: Add tests with mock resource managers
>>    drm/ttm/tests: Add test cases dependent on fence signaling
>>
>>   drivers/gpu/drm/Kconfig                       |   1 +
>>   drivers/gpu/drm/ttm/tests/.kunitconfig        |   1 +
>>   drivers/gpu/drm/ttm/tests/Makefile            |   5 +
>>   drivers/gpu/drm/ttm/tests/ttm_bo_test.c       | 622 ++++++++++++++
>>   .../gpu/drm/ttm/tests/ttm_bo_validate_test.c  | 795 ++++++++++++++++++
>>   drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 109 ++-
>>   drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h |   7 +
>>   drivers/gpu/drm/ttm/tests/ttm_mock_manager.c  | 207 +++++
>>   drivers/gpu/drm/ttm/tests/ttm_mock_manager.h  |  31 +
>>   drivers/gpu/drm/ttm/tests/ttm_pool_test.c     |   3 +-
>>   drivers/gpu/drm/ttm/tests/ttm_resource_test.c | 335 ++++++++
>>   drivers/gpu/drm/ttm/tests/ttm_tt_test.c       | 282 +++++++
>>   drivers/gpu/drm/ttm/ttm_resource.c            |   3 +
>>   drivers/gpu/drm/ttm/ttm_tt.c                  |   3 +
>>   14 files changed, 2401 insertions(+), 3 deletions(-)
>>   create mode 100644 drivers/gpu/drm/ttm/tests/ttm_bo_test.c
>>   create mode 100644 drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
>>   create mode 100644 drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
>>   create mode 100644 drivers/gpu/drm/ttm/tests/ttm_mock_manager.h
>>   create mode 100644 drivers/gpu/drm/ttm/tests/ttm_resource_test.c
>>   create mode 100644 drivers/gpu/drm/ttm/tests/ttm_tt_test.c
>>



More information about the dri-devel mailing list