[Intel-gfx] [PATCH v2 2/2] drm/i915: Remove unused/wrong INF_UNIT_LEVEL_CLKGATE

Matt Roper matthew.d.roper at intel.com
Mon Feb 6 17:08:52 UTC 2023


On Mon, Feb 06, 2023 at 08:54:10AM -0800, Lucas De Marchi wrote:
> INF_UNIT_LEVEL_CLKGATE is not replicated, but since it's not actually
> used it can just be removed.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

Looks like the only reference to the register was removed in

	commit eee42141e498fa3df3ce524846d52f67a92b6845
	Author:     Matt Roper <matthew.d.roper at intel.com>
	AuthorDate: Tue Jul 13 12:36:35 2021 -0700
	Commit:     Matt Roper <matthew.d.roper at intel.com>
	CommitDate: Wed Jul 14 17:49:02 2021 -0700

	    drm/i915/icl: Drop workarounds that only apply to pre-production steppings

> ---
>  drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> index cc1539c7a6b6..7256f7e3fd11 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> @@ -769,9 +769,6 @@
>  #define GEN10_DFR_RATIO_EN_AND_CHICKEN		MCR_REG(0x9550)
>  #define   DFR_DISABLE				(1 << 9)
>  
> -#define INF_UNIT_LEVEL_CLKGATE			MCR_REG(0x9560)
> -#define   CGPSF_CLKGATE_DIS			(1 << 3)
> -
>  #define MICRO_BP0_0				_MMIO(0x9800)
>  #define MICRO_BP0_2				_MMIO(0x9804)
>  #define MICRO_BP0_1				_MMIO(0x9808)
> -- 
> 2.39.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the dri-devel mailing list