[PATCH v3] drm/ast: Fix start address computation

Jocelyn Falempe jfalempe at redhat.com
Fri Feb 10 15:02:23 UTC 2023


On 10/02/2023 01:33, Jammy Huang wrote:
> 
> On 2023/2/9 下午 05:55, Thomas Zimmermann wrote:
>>
>>
>> Am 09.02.23 um 10:44 schrieb Jocelyn Falempe:
>>> During the driver conversion to shmem, the start address for the
>>> scanout buffer was set to the base PCI address.
>>> In most cases it works because only the lower 24bits are used, and
>>> due to alignment it was almost always 0.
>>> But on some unlucky hardware, it's not the case, and some unitilized
>>
>> 'uninitialized'
>>
>>> memory is displayed on the BMC.
>>> With shmem, the primary plane is always at offset 0 in GPU memory.
>>>
>>>   * v2: rewrite the patch to set the offset to 0. (Thomas Zimmermann)
>>>   * v3: move the change to plane_init() and also fix the cursor plane.
>>>         (Jammy Huang)
>>>
>>> Tested on a sr645 affected by this bug.
>>>
>>> Fixes: f2fa5a99ca81 ("drm/ast: Convert ast to SHMEM")
>>> Signed-off-by: Jocelyn Falempe <jfalempe at redhat.com>
>>
>> Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>
> 
> Reviewed-by: Jammy Huang <jammy_huang at aspeedtech.com>

I just pushed it to drm-misc-fixes.

Thanks a lot,

-- 

Jocelyn




More information about the dri-devel mailing list