[PATCH 1/3] drm: rcar-du: lvds: Call function directly instead of through pointer

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Wed Feb 15 06:18:33 UTC 2023


On 14/02/2023 02:37, Laurent Pinchart wrote:
> When disabling the companion bridge in rcar_lvds_atomic_disable(),
> there's no need to go through the bridge's operations to call
> .atomic_disable(). Call rcar_lvds_atomic_disable() on the companion
> directly.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> ---
>   drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 260ea5d8624e..61de18af62e6 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -582,8 +582,7 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge,
>   
>   	/* Disable the companion LVDS encoder in dual-link mode. */
>   	if (lvds->link_type != RCAR_LVDS_SINGLE_LINK && lvds->companion)
> -		lvds->companion->funcs->atomic_disable(lvds->companion,
> -						       old_bridge_state);
> +		rcar_lvds_atomic_disable(lvds->companion, old_bridge_state);
>   
>   	pm_runtime_put_sync(lvds->dev);
>   }

Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas at ideasonboard.com>

  Tomi



More information about the dri-devel mailing list