[PATCH v3 2/7] media: Add Y210, Y212 and Y216 formats

[Nicolas Dufresne]

Le jeudi 23 février 2023 à 15:10 +0200, Tomi Valkeinen a écrit :
> Hi,
> 
> On 22/02/2023 17:28, Nicolas Dufresne wrote:
> > Hi Tomi,
> > 
> > Le mercredi 21 décembre 2022 à 11:24 +0200, Tomi Valkeinen a écrit :
> > > Add Y210, Y212 and Y216 formats.
> > > 
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas at ideasonboard.com>
> > > ---
> > >   .../media/v4l/pixfmt-packed-yuv.rst           | 49 ++++++++++++++++++-
> > >   drivers/media/v4l2-core/v4l2-ioctl.c          |  3 ++
> > >   include/uapi/linux/videodev2.h                |  8 +++
> > >   3 files changed, 58 insertions(+), 2 deletions(-)
> > 
> > It seems you omitted to update v4l2-common.c, Ming Qian had made a suplicated
> > commit for this, I'll ask him if he can keep the -common changes you forgot.
> 
> Ah, I wasn't aware of the format list in that file.
> 
> I think you refer to the "media: imx-jpeg: Add support for 12 bit 
> extended jpeg" series. Yes, I'm fine if he can add the -common changes 
> there, but I can also send a separate patch. In fact, maybe a separate 
> fix patch is better, so that we can have it merged in the early 6.3 rcs.

I don't think we need to worry about backporting this though. I simply care that
we keep updating -common and encourage using it. The goal of this lib is to
provide a common set of helpers to do calculate format related information. You
don't have to use it at any cost. Allocation is often the cause of memory
corruption issues, and is a very recurrent thing we have to debug and fix.

This was also discussed on IRC yesterday, for Renesas driver, "just porting it"
to use that could mean duplicating the lookup, as Renesas driver also needs its
own map to get the HW specific formats and other information. This looks like a
valid use case to me, and is definitely something -common could improve on.

Nicolas