[PATCH] drm/tests: helpers: Drop empty platform remove function
Maíra Canal
mcanal at igalia.com
Sat Feb 25 15:25:07 UTC 2023
On 2/24/23 19:14, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Reviewed-by: Maíra Canal <mcanal at igalia.com>
Best Regards,
- Maíra Canal
> ---
> Hello,
>
> the remove function was introduced in commit 57a84a97bbda ("drm/tests:
> helpers: Make sure the device is bound").
>
> Best regards
> Uwe
>
> drivers/gpu/drm/tests/drm_kunit_helpers.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index e98b4150f556..4df47071dc88 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -19,14 +19,8 @@ static int fake_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int fake_remove(struct platform_device *pdev)
> -{
> - return 0;
> -}
> -
> static struct platform_driver fake_platform_driver = {
> .probe = fake_probe,
> - .remove = fake_remove,
> .driver = {
> .name = KUNIT_DEVICE_NAME,
> },
More information about the dri-devel
mailing list