[PATCH] drm/shmem-helper: Fix compile error

Dmitry Osipenko dmitry.osipenko at collabora.com
Tue Feb 28 15:06:09 UTC 2023


On 2/28/23 17:40, Jani Nikula wrote:
...
>>> And the build is indeed currently broken.
>>>
>>> Moreover, when the build was fine for a while, apparently the changes in
>>> shmem broke a bunch of machines in Intel CI. And due to this, we aren't
>>> getting any CI results for incoming patches right now.
>>
>> Is there any plans for fixing it?
> 
> Someone(tm) needs to step up and do it. Personally, I'm clueless.
> 
> The whole thing is made worse by the conflict and the various
> resolutions. At this time, I'm not certain whether the whole thing was
> broken to begin with, or if it's just the conflict resolution that
> caused the issues.
> 
> I'll just note that for future reference, Cc'ing intel-gfx for anything
> non-trivial touching the guts of drm will be useful for running CI on
> our test farm pre-merge. Now, we don't know.

Apparently, there is a missing lock for dma-buf vgem (and probably some
other similar drivers) exporting code path that I missed before. I've
reproduced the IGT warning locally and looking into fixing it. Will keep
updating you on it. Thanks for reporting it!

-- 
Best regards,
Dmitry



More information about the dri-devel mailing list