[PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

Thomas Zimmermann tzimmermann at suse.de
Tue Feb 28 15:46:03 UTC 2023


Hi

Am 28.02.23 um 16:28 schrieb Dmitry Osipenko:
> On 2/28/23 18:26, Thomas Zimmermann wrote:
>> This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0.
>>
>> The locking appears incomplete. A caller of SHMEM helper's pin
>> function never acquires the dma-buf reservation lock. So we get
>>
>>    WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem_shmem_helper.c:243 drm_gem_shmem_pin+0x42/0x90 [drm_shmem_helper]
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> ---
> 
> Thanks Thomas,
> 
> Acked-by: Dmitry Osipenko <dmitry.osipenko at collabora.com>
> 

Thanks, merged now. I hope this fixes the immediate issues.

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230228/cdd5b204/attachment.sig>


More information about the dri-devel mailing list