[PATCH 09/18] vfio-mdev/mdpy-fb: Do not set struct fb_info.apertures

[Thomas Zimmermann]

Am 20.12.22 um 10:32 schrieb Javier Martinez Canillas:
> [adding Kirti Wankhede and kvm at vger.kernel.org to Cc list]
> 
> On 12/19/22 17:05, Thomas Zimmermann wrote:
>> Generic fbdev drivers use the apertures field in struct fb_info to
>> control ownership of the framebuffer memory and graphics device. Do
>> not set the values in mdpy-fb.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> ---
>>   samples/vfio-mdev/mdpy-fb.c | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
>> index 9ec93d90e8a5..1de5801cd2e8 100644
>> --- a/samples/vfio-mdev/mdpy-fb.c
>> +++ b/samples/vfio-mdev/mdpy-fb.c
>> @@ -161,14 +161,6 @@ static int mdpy_fb_probe(struct pci_dev *pdev,
>>   		goto err_release_fb;
>>   	}
>>   
>> -	info->apertures = alloc_apertures(1);
>> -	if (!info->apertures) {
>> -		ret = -ENOMEM;
>> -		goto err_unmap;
>> -	}
>> -	info->apertures->ranges[0].base = info->fix.smem_start;
>> -	info->apertures->ranges[0].size = info->fix.smem_len;
>> -
>>   	info->fbops = &mdpy_fb_ops;
>>   	info->flags = FBINFO_DEFAULT;
>>   	info->pseudo_palette = par->palette;
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
> 
> But I think an ack from Kirti Wankhede or other virt folk is needed if you
> want to merge this through drm-misc-next.

ping. Could I have a review from the vfio devs, please.

Best regards
Thomas

> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230103/f4317894/attachment-0001.sig>