[PATCH v4 27/27] drm/amd: Optimize SRIOV switch/case for PSP microcode load

[Limonciello, Mario]

[Public]



> -----Original Message-----
> From: Christian König <ckoenig.leichtzumerken at gmail.com>
> Sent: Wednesday, January 4, 2023 07:18
> To: Limonciello, Mario <Mario.Limonciello at amd.com>; Deucher, Alexander
> <Alexander.Deucher at amd.com>; linux-kernel at vger.kernel.org
> Cc: Pan, Xinhui <Xinhui.Pan at amd.com>; Lazar, Lijo <Lijo.Lazar at amd.com>;
> Javier Martinez Canillas <javierm at redhat.com>; dri-
> devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org; Daniel Vetter
> <daniel at ffwll.ch>; Carlos Soriano Sanchez <csoriano at redhat.com>; David
> Airlie <airlied at gmail.com>; Koenig, Christian <Christian.Koenig at amd.com>
> Subject: Re: [PATCH v4 27/27] drm/amd: Optimize SRIOV switch/case for PSP
> microcode load
> 
> Am 03.01.23 um 23:18 schrieb Mario Limonciello:
> > Now that IP version decoding is used, a number of case statements
> > can be combined.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
> 
> This patch can probably be pushed as small cleanup independent of the
> previous patches.
> 
> In general I usually suggest to push those separately to make the patch
> set concentrate on the real changes at hand.
> 
> Anyway this patch here is Reviewed-by: Christian König
> <christian.koenig at amd.com>
> 

Thanks!
This optimization is only possible because of earlier changes in the series.
Will add your tag for v5.

> Regards,
> Christian.
> 
> > ---
> > v3->v4:
> >   * New patch
> >
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 +-------
> >   1 file changed, 1 insertion(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> > index f45362dd8228..83e253b5d928 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> > @@ -132,14 +132,8 @@ static int psp_init_sriov_microcode(struct
> psp_context *psp)
> >
> >   	switch (adev->ip_versions[MP0_HWIP][0]) {
> >   	case IP_VERSION(9, 0, 0):
> > -		adev->virt.autoload_ucode_id =
> AMDGPU_UCODE_ID_CP_MEC2;
> > -		ret = psp_init_cap_microcode(psp, ucode_prefix);
> > -		break;
> > -	case IP_VERSION(11, 0, 9):
> > -		adev->virt.autoload_ucode_id =
> AMDGPU_UCODE_ID_CP_MEC2;
> > -		ret = psp_init_cap_microcode(psp, ucode_prefix);
> > -		break;
> >   	case IP_VERSION(11, 0, 7):
> > +	case IP_VERSION(11, 0, 9):
> >   		adev->virt.autoload_ucode_id =
> AMDGPU_UCODE_ID_CP_MEC2;
> >   		ret = psp_init_cap_microcode(psp, ucode_prefix);
> >   		break;