[PATCH v4 3/7] accel/ivpu: Add GEM buffer object management
Stanislaw Gruszka
stanislaw.gruszka at linux.intel.com
Fri Jan 6 13:22:55 UTC 2023
On Fri, Jan 06, 2023 at 11:50:05AM +0100, Daniel Vetter wrote:
> On Thu, Dec 08, 2022 at 12:07:29PM +0100, Jacek Lawrynowicz wrote:
> > Adds four types of GEM-based BOs for the VPU:
> > - shmem
> > - userptr
> > - internal
>
> Uh what do you need this for? Usually the way we do these is just alloce a
> normal bo, and then pin them.
I think we do alloc/pin this way, but all our bo's are GEM based.
For those bo's we use internally and other non-shmem we create them
with drm_gem_private_object_init(). I think this way is simpler than
have separate code for non-GEM and GEM bo's ...
> Also, gem shmem helpers should be able to mostly cover you here, why not
> use those? Might need some work to push basic userptr to them, but we have
> enough drivers reinventing that wheel to justify that work.
>
> Can I guess also be done after merging.
... but if not, we can add this to TODO.
Regards
Stanislaw
More information about the dri-devel
mailing list