[PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

Daniel Vetter daniel at ffwll.ch
Fri Jan 6 18:57:51 UTC 2023


On Thu, Jan 05, 2023 at 09:16:36PM +0100, Uwe Kleine-König wrote:
> Hello Daniel,
> 
> On Thu, Jan 05, 2023 at 03:33:13PM +0100, Daniel Vetter wrote:
> > On Tue, Dec 20, 2022 at 08:24:18AM +0100, Thomas Zimmermann wrote:
> > > Hi
> > > 
> > > Am 19.12.22 um 19:31 schrieb Uwe Kleine-König:
> > > > There is a local variable that contains dev->driver. Make use of it
> > > > instead of "open coding" it.
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > > 
> > > Added to drm-misc-next. Thanks a lot.
> > 
> > Given that Uwe has a pile of drm commits all over, time for drm-misc
> > commit rights?
> 
> I feel honored, but if you ask me, that's not necessary/sensible. At
> least up to now my patches are more or less drive-by changes and letting
> them go through someone else with commit access is fine for me. There is
> no driver in the drm area I feel responsible for.
> 
> Or is this about reducing maintainer load on your end?

Yes :-)

Essentially it gives you the keys to drive your own patches, all you have
to do is find someone to review them for you (trading review works best).
And since all regulars have commit rights there's otherwise big confusion
whether patches should be pushed or not. Which means they routinely fall
through cracks and need extra attention from everyone involved.

Also note that commit rights does not mean you assume maintainer
responsibilities for anything (ofc your review is appreciated where you
can help out), that's still separate and tracked in MAINTAINERS as usual.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list