[PATCH 0/5] Check for valid framebuffer's format
Maíra Canal
mcanal at igalia.com
Mon Jan 9 10:58:03 UTC 2023
This series is a follow-up of [1] in which I introduced a check for valid
formats on drm_gem_fb_create(). During the discussion, I realized that would be
a better idea to put the check inside framebuffer_check() so that it wouldn't
be needed to hit any driver-specific code path when the check fails. Thanks
to Daniel, Simon, Rob and Thomas for the insightful discussion!
Therefore, add the valid format check inside framebuffer_check() and remove
the same check from the drivers. Adding the check to framebuffer_check() will
guarantee that the igt at kms_addfb_basic@addfb25-bad-modifier IGT test passes,
showing the correct behavior of the check.
This patchset was tested on i915, amdgpu, and vc4 with the IGT tests.
[1] https://lore.kernel.org/dri-devel/20230103125322.855089-1-mcanal@igalia.com/T/
Best Regards,
- Maíra Canal
Maíra Canal (5):
drm/framebuffer: Check for valid formats
drm/amdgpu: Remove redundant framebuffer format check
drm/i915: Remove redundant framebuffer format check
drm/vmwgfx: Remove redundant framebuffer format check
drm/plane: Unexport drm_any_plane_has_format()
Documentation/gpu/todo.rst | 9 ++++-----
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 ----------
drivers/gpu/drm/drm_framebuffer.c | 8 ++++++++
drivers/gpu/drm/drm_plane.c | 1 -
drivers/gpu/drm/i915/display/intel_fb.c | 9 ---------
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 18 ------------------
6 files changed, 12 insertions(+), 43 deletions(-)
--
2.39.0
More information about the dri-devel
mailing list