[PATCH] drm/mxsfb: improve clk handling for axi clk

Marek Vasut marex at denx.de
Tue Jan 10 10:33:09 UTC 2023


On 1/10/23 11:06, Javier Martinez Canillas wrote:
> On 1/10/23 10:26, Javier Martinez Canillas wrote:
>> Hello Uwe,
>>
>> On 7/20/20 17:32, Uwe Kleine-König wrote:
>>> Ignoring errors from devm_clk_get() is wrong. To handle not all platforms
>>> having an axi clk use devm_clk_get_optional() instead and do proper error
>>> handling.
>>>
>>> Also the clk API handles NULL as a dummy clk (which is also returned by
>>> devm_clk_get_optional() if there is no clk) so there is no need to check
>>> for NULL before calling clk_prepare_enable() or its counter part.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>>
>> Patch looks good to me.
>>
>> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
>>
> 
> I've pushed this to drm-misc (dri-misc-next) now. Thanks!

Thanks, I admit, I missed the patch, sorry.

It does indeed look correct.

Reviewed-by: Marek Vasut <marex at denx.de>


More information about the dri-devel mailing list