[PATCH v2] drm/nouveau: Remove file nouveau_fbcon.c

Thomas Zimmermann tzimmermann at suse.de
Tue Jan 10 12:53:48 UTC 2023



Am 10.01.23 um 13:49 schrieb Javier Martinez Canillas:
> Hello Thomas,
> 
> On 1/10/23 13:35, Thomas Zimmermann wrote:
>> Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
>> converted nouveau to generic fbdev emulation. The driver's internal
>> implementation later got accidentally restored during a merge commit.
>> Remove the file from the driver. No functional changes.
>>
>> v2:
>> 	* point Fixes tag to merge commit (Alex)
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>> Fixes: 4e291f2f5853 ("Merge tag 'drm-misc-next-2022-11-10-1' of git://anongit.freedesktop.org/drm/drm-misc into drm-next")
> 
> I believe the fixes tag should be before the S-o-B ? At least that is
> the case in most commits and Documentation/process/maintainer-tip.rst
> example. But you could fix it just before applying.

I'll do.

> 
> The patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
> 

Thanks.

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230110/c5c28fa7/attachment.sig>


More information about the dri-devel mailing list