[PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes

Gerd Hoffmann kraxel at redhat.com
Thu Jan 12 07:17:19 UTC 2023


  Hi,

> > > I think we need to do a bit of refactoring/documenting here first.
> > [Kasireddy, Vivek] Just for reference, here is Dave's commit that added this
> > property for qxl:
> > commit 4695b03970df378dcb93fe3e7158381f1e980fa2
> > Author: Dave Airlie <airlied at redhat.com>
> > Date:   Fri Oct 11 11:05:00 2013 +1000
> > 
> >     qxl: add a connector property to denote hotplug should rescan modes.
> > 
> >     So GNOME userspace has an issue with when it rescans for modes on hotplug
> >     events, if the monitor has no EDID it assumes that nothing has changed on
> >     EDID as with real hw we'd never have new modes without a new EDID, and they
> >     kind off rely on the behaviour now, however with virtual GPUs we would
> >     like to rescan the modes and get a new preferred mode on hotplug events
> >     to handle dynamic guest resizing (where you resize the host window and the
> >     guest resizes with it).
> 
> Ok this is just terrible. Because _anything_ without an EDID is impacted,
> and we're certainly not going to sprinkle this property all over gpu
> drivers just so Gnome takes the right path.

Oh, and (newer) virtio-gpu actually has EDIDs ...

take care,
  Gerd



More information about the dri-devel mailing list