[RFC PATCH 2/4] drm/msm/mdss: correct the ubwc version for sm6115 platform

Abhinav Kumar quic_abhinavk at quicinc.com
Fri Jan 13 21:39:45 UTC 2023



On 1/13/2023 1:16 PM, Dmitry Baryshkov wrote:
> On Fri, 13 Jan 2023 at 21:47, Abhinav Kumar <quic_abhinavk at quicinc.com> wrote:
>> On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
>>> According to the vendor DT, sm6115 has UBWC 1.0, not 2.0.
>>>
>>
>> Can you please point me to which file you are referring to?
>>
>> The internal docs I have are still showing 2.0.
> 
> If I understood correctly sm6115 = bengal, thus:
> 
> https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/bengal-sde.dtsi#103

Ok, so the cause of discrepancy was that the overall recommendation 
across sub-systems was to use UWBC 1.0. Thats why the DTSI has 1.0.

Hence, this change LGTM,

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

> 
>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>> ---
>>>    drivers/gpu/drm/msm/msm_mdss.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
>>> index 2219c1bd59a9..4401f945b966 100644
>>> --- a/drivers/gpu/drm/msm/msm_mdss.c
>>> +++ b/drivers/gpu/drm/msm/msm_mdss.c
>>> @@ -532,7 +532,7 @@ static const struct msm_mdss_data sm8150_data = {
>>>    };
>>>
>>>    static const struct msm_mdss_data sm6115_data = {
>>> -     .ubwc_version = UBWC_2_0,
>>> +     .ubwc_version = UBWC_1_0,
>>>        .ubwc_swizzle = 7,
>>>        .ubwc_static = 0x11f,
>>>    };
> 
> 
> 


More information about the dri-devel mailing list