[PATCH 2/3] drm/amdgpu/vcn: Deduplicate indirect SRAM checking code

Guilherme G. Piccoli gpiccoli at igalia.com
Mon Jan 16 21:51:28 UTC 2023


On 16/01/2023 18:41, Alex Deucher wrote:
> [...]
>> +       case IP_VERSION(4, 0, 0):       /* Vega10 */
> 
> This comment is incorrect.  Vega10 does not have VCN (it has UVD and VCE).
> 
> Alex

Thanks Alex! I'll resubmit V2 with this comment removed.

I've stolen it from
https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c#L1147
, but obviously I misunderstood the mapping here heheh

Cheers,


Guilherme


More information about the dri-devel mailing list