[PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

Alex Deucher alexdeucher at gmail.com
Mon Jan 16 23:00:08 UTC 2023


On Mon, Jan 16, 2023 at 5:34 PM Guilherme G. Piccoli
<gpiccoli at igalia.com> wrote:
>
> On 16/01/2023 19:27, Liu, Leo wrote:
> > Secure part requires PSP load VCN boot sequence which is with indirect
> > sram mode.
> >
> > Regards,
> > Leo
>
> With that said, and with the plans of just setting the indirect sram
> mode nevertheless (with no switch/cases anymore - I'll submit the V2
> tomorrow if everybody agrees), does anybody oppose to have this
> parameter for debug reasons?

It's not clear to me when this would be used.  We only disable it
briefly during new asic bring up, after that we never touch it again.
No end user on production hardware should ever have to change it and
doing so would break VCN on their system.

Alex

>
> I first considered doing through debugfs, but obviously was a (very) bad
> idea, since this should be an early boot tuning heheh
>
> Cheers,
>
>
> Guilherme


More information about the dri-devel mailing list