[PATCH 2/6] drm: rcar-du: lvds: Add reset control

[Geert Uytterhoeven]

Hi Tomi,

On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen
<tomi.valkeinen+renesas at ideasonboard.com> wrote:
> From: Koji Matsuoka <koji.matsuoka.xm at renesas.com>
>
> Reset LVDS using the reset control as CPG reset/release is required in
> H/W manual sequence.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm at renesas.com>
> Signed-off-by: LUU HOAI <hoai.luu.ub at renesas.com>
> [tomi.valkeinen: Rewrite the patch description]
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas at ideasonboard.com>

Thanks for your patch!

> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c

> @@ -844,6 +853,12 @@ static int rcar_lvds_probe(struct platform_device *pdev)
>         if (ret < 0)
>                 return ret;
>
> +       lvds->rstc = devm_reset_control_get(&pdev->dev, NULL);

devm_reset_control_get_exclusive()

> +       if (IS_ERR(lvds->rstc)) {
> +               dev_err(&pdev->dev, "failed to get cpg reset\n");
> +               return PTR_ERR(lvds->rstc);

return dev_err_probe(...);

> +       }
> +
>         drm_bridge_add(&lvds->bridge);
>
>         return 0;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds