[RFC PATCH] drm/msm/dpu: enable DPU_MDP_AUDIO_SELECT for sc8180x

Abhinav Kumar quic_abhinavk at quicinc.com
Wed Jan 18 18:48:18 UTC 2023



On 1/15/2023 6:00 AM, Dmitry Baryshkov wrote:
> According to the discussion ([1]) on the mailing list, platforms before
> sm8250 (and derivatives) should program HDMI_DP_CORE_SELECT register to
> route audio to the DP ports. Enable DPU_MDP_AUDIO_SELECT on sc8180x to
> program correponding register.
> 
> [1] https://lore.kernel.org/all/f86504ba-835a-6e30-6c30-8bb89b1359c4@quicinc.com/
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

Yes, I confirm this is correct, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 2664fa3665b0..b94b0a772ca8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -550,7 +550,7 @@ static const struct dpu_mdp_cfg sc8180x_mdp[] = {
>   	{
>   	.name = "top_0", .id = MDP_TOP,
>   	.base = 0x0, .len = 0x45C,
> -	.features = 0,
> +	.features = BIT(DPU_MDP_AUDIO_SELECT),
>   	.highest_bank_bit = 0x3,
>   	.clk_ctrls[DPU_CLK_CTRL_VIG0] = {
>   			.reg_off = 0x2AC, .bit_off = 0},


More information about the dri-devel mailing list