[Intel-gfx] [PATCH v5 2/6] drm/i915/pxp: add device link between i915 and mei_pxp

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Thu Jan 19 23:01:14 UTC 2023


Thanks for reviewing the patch. I will fix the code according to your recommendation.
I assume we could probably go with -ENOLINK as the error (instead of -ENOMEM).
However, i'll wait for Alexander to respond on whether he needs drm_WARN_ON and your question on RPM.

...alan

On Thu, 2023-01-19 at 14:25 -0500, Vivi, Rodrigo wrote:
> On Thu, Jan 12, 2023 at 05:18:46PM -0800, Alan Previn wrote:
> > From: Alexander Usyskin <alexander.usyskin at intel.com>
> > 
> > Add device link with i915 as consumer and mei_pxp as supplier
> > to ensure proper ordering of power flows.
> > 
> > V2: condition on absence of heci_pxp to filter out DG
> > 
> > Signed-off-by: Alexander Usyskin <alexander.usyskin at intel.com>
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis at intel.com>
> > ---
> >  drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
Alan: [snip]


More information about the dri-devel mailing list