[Intel-gfx] [PATCH v2 7/8] drm/i915: Convert MBUS_ABOX_CTL() to _PICK_EVEN_2RANGES()

[Srivatsa, Anusha]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Lucas
> De Marchi
> Sent: Friday, January 20, 2023 11:35 AM
> To: intel-gfx at lists.freedesktop.org
> Cc: De Marchi, Lucas <lucas.demarchi at intel.com>; dri-
> devel at lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 7/8] drm/i915: Convert MBUS_ABOX_CTL() to
> _PICK_EVEN_2RANGES()
>
> MBUS_ABOX_CTL() can use _PICK_EVEN_2RANGES instead of _PICK, which
> reduces the size and is safer.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Looks good!

Reviewed-by: Anusha Srivatsa <anusha.srivatsa at intel.com>

> ---
>  drivers/gpu/drm/i915/i915_reg.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index fe6385443c4a..3d6ad4424265 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1040,9 +1040,11 @@
>  #define _MBUS_ABOX0_CTL                      0x45038
>  #define _MBUS_ABOX1_CTL                      0x45048
>  #define _MBUS_ABOX2_CTL                      0x4504C
> -#define MBUS_ABOX_CTL(x)             _MMIO(_PICK(x, _MBUS_ABOX0_CTL,
> \
> -                                                 _MBUS_ABOX1_CTL, \
> -                                                 _MBUS_ABOX2_CTL))
> +#define MBUS_ABOX_CTL(x)
>       \
> +     _MMIO(_PICK_EVEN_2RANGES(x, 2,
>               \
> +                              _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,
>               \
> +                              _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
> +
>  #define MBUS_ABOX_BW_CREDIT_MASK     (3 << 20)
>  #define MBUS_ABOX_BW_CREDIT(x)               ((x) << 20)
>  #define MBUS_ABOX_B_CREDIT_MASK              (0xF << 16)
> --
> 2.39.0