[Intel-gfx] [PATCH 5/5] drm/ttm: replace busy placement with flags v2
kernel test robot
lkp at intel.com
Wed Jan 25 11:31:47 UTC 2023
Hi Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-ttm-stop-allocating-dummy-resources-during-BO-creation/20230124-205939
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link: https://lore.kernel.org/r/20230124125726.13323-5-christian.koenig%40amd.com
patch subject: [Intel-gfx] [PATCH 5/5] drm/ttm: replace busy placement with flags v2
config: i386-defconfig (https://download.01.org/0day-ci/archive/20230125/202301251900.qqxH4BLi-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/1b5a737f3331c8493708ed779338243cd70dde6a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Christian-K-nig/drm-ttm-stop-allocating-dummy-resources-during-BO-creation/20230124-205939
git checkout 1b5a737f3331c8493708ed779338243cd70dde6a
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 olddefconfig
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
In function 'i915_ttm_placement_from_obj',
inlined from 'i915_ttm_get_pages' at drivers/gpu/drm/i915/gem/i915_gem_ttm.c:841:2:
>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c:165:25: error: 'places[0].flags' is used uninitialized [-Werror=uninitialized]
165 | places[0].flags |= TTM_PL_FLAG_IDLE;
| ^~
drivers/gpu/drm/i915/gem/i915_gem_ttm.c: In function 'i915_ttm_get_pages':
drivers/gpu/drm/i915/gem/i915_gem_ttm.c:831:26: note: 'places' declared here
831 | struct ttm_place places[I915_TTM_MAX_PLACEMENTS + 1];
| ^~~~~~
cc1: all warnings being treated as errors
vim +165 drivers/gpu/drm/i915/gem/i915_gem_ttm.c
155
156 static void
157 i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
158 struct ttm_place *places,
159 struct ttm_placement *placement)
160 {
161 unsigned int num_allowed = obj->mm.n_placements;
162 unsigned int flags = obj->flags;
163 unsigned int i;
164
> 165 places[0].flags |= TTM_PL_FLAG_IDLE;
166 i915_ttm_place_from_region(num_allowed ? obj->mm.placements[0] :
167 obj->mm.region, &places[0], obj->bo_offset,
168 obj->base.size, flags);
169
170 /* Cache this on object? */
171 for (i = 0; i < num_allowed; ++i) {
172 i915_ttm_place_from_region(obj->mm.placements[i],
173 &places[i + 1], obj->bo_offset,
174 obj->base.size, flags);
175 places[i + 1].flags |= TTM_PL_FLAG_BUSY;
176 }
177
178 placement->num_placement = num_allowed + 1;
179 placement->placement = places;
180 }
181
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
More information about the dri-devel
mailing list