[PATCH 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example

[Jon Cormier]

On Thu, Jan 26, 2023 at 10:40 AM Krzysztof Kozlowski <
krzysztof.kozlowski at linaro.org> wrote:

> On 25/01/2023 22:09, Jonathan Cormier wrote:
> > Add a i2c example with HDMI connector
>
> Why? It's the same - but more on this below.
>
The existing example is for the previous setup where it was configured as
its own device.  It seemed necessary now that the driver is going to
support being connected to an i2c bus to show it being used as such.

>
> >
> > Signed-off-by: Jonathan Cormier <jcormier at criticallink.com>
>
> You need to test the bindings before sending and fix the errors.
>
Will do

>
> > ---
> >  .../bindings/display/bridge/ti,tfp410.yaml         | 42
> ++++++++++++++++++++++
> >  1 file changed, 42 insertions(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml
> b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml
> > index 4c5dd8ec2951..456214f14b47 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml
> > @@ -116,4 +116,46 @@ examples:
> >          };
> >      };
> >
> > +  - |
> > +    i2c {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      hdmi_encoder: tfp410 at 38 {
>
> Node names should be generic.
>
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> Can do

> > +        compatible = "ti,tfp410";
> > +        reg = <0x38>;
> > +
> > +        ports {
> > +          address-cells = <1>;
> > +          size-cells = <0>;
> > +
> > +          port at 0 {
> > +            reg = <0>;
> > +            tfp410_in: endpoint {
> > +              remote-endpoint = <&dpi1_out>;
> > +            };
> > +          };
> > +
> > +          port at 1 {
> > +            reg = <1>;
> > +            tfp410_out: endpoint {
> > +              remote-endpoint = <&hdmi_connector_in>;
> > +            };
>
> That's the same example as existing one, so it looks useless. I don't
> see benefits of this example.
>
It's mostly the same, except defined inside an i2c bus, with the reg value
set. Without the powerdown-gpios or ti,deskew.
And without the pclk-sample and bus-width (these are now read from i2c)
And I included the hdmi_connector so it would be a more complete and useful
example of how it could be used.  The TFP410 doesn't handle the ddc i2c bus
on its own so a separate connector node is needed.  I'll drop it if that's
preferred.

>
> > +          };
> > +        };
> > +      };
> > +    };
> > +
> > +    hdmi: hdmi_connector {
>
> Drop. Incorrect name and not really related.
>
> > +      compatible = "hdmi-connector";
> > +      label = "hdmi";
> > +      type = "a";
> > +      ddc-i2c-bus = <&i2c1>;
> > +      port {
> > +        hdmi_connector_in: endpoint {
> > +          remote-endpoint = <&tfp410_out>;
> > +        };
> > +      };
> > +    };
> > +
> >  ...
> >
>
> Best regards,
> Krzysztof
>
>

-- 
Jonathan Cormier
Software Engineer

Voice:  315.425.4045 x222



http://www.CriticalLink.com <http://www.criticallink.com/>
6712 Brooklawn Parkway, Syracuse, NY 13211

<https://www.linkedin.com/company/critical-link-llc>
<https://twitter.com/Critical_Link>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230126/66da7bc2/attachment.htm>