[PATCH] drm/amdgpu/display/mst: fix an unused-variable warning
Hamza Mahfooz
hamza.mahfooz at amd.com
Thu Jan 26 21:07:21 UTC 2023
On 1/26/23 11:35, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
>
> The newly added code is in an #ifdef, so the variables that
> are only used in there cause a warning if CONFIG_DRM_AMD_DC_DCN
> is disabled:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_atomic_check':
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9698:43: error: unused variable 'mst_state' [-Werror=unused-variable]
> 9698 | struct drm_dp_mst_topology_state *mst_state;
> | ^~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9697:41: error: unused variable 'mgr' [-Werror=unused-variable]
> 9697 | struct drm_dp_mst_topology_mgr *mgr;
> | ^~~
>
> Fixes: c689e1e362ea ("drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments")
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index be1232356f9e..c966bb05f6c7 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -9694,8 +9694,10 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
> struct drm_connector_state *old_con_state, *new_con_state;
> struct drm_crtc *crtc;
> struct drm_crtc_state *old_crtc_state, *new_crtc_state;
> +#if defined(CONFIG_DRM_AMD_DC_DCN)
> struct drm_dp_mst_topology_mgr *mgr;
> struct drm_dp_mst_topology_state *mst_state;
> +#endif
> struct drm_plane *plane;
> struct drm_plane_state *old_plane_state, *new_plane_state;
> enum dc_status status;
--
Hamza
More information about the dri-devel
mailing list