[PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

Hamza Mahfooz hamza.mahfooz at amd.com
Fri Jan 27 14:24:10 UTC 2023


Hey Greg,

On 1/27/23 02:39, Greg KH wrote:
> On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote:
>> On 1/20/2023 11:46, Guenter Roeck wrote:
>>> On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote:
>>>> This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f.
>>>>
>>>> [Why]
>>>> Changes cause regression on amdgpu mst.
>>>> E.g.
>>>> In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload
>>>> one by one and call fill_dc_mst_payload_table_from_drm() to update the HW
>>>> maintained payload table. But previous change tries to go through all the
>>>> payloads in mst_state and update amdpug hw maintained table in once everytime
>>>> driver only tries to add/remove a specific payload stream only. The newly
>>>> design idea conflicts with the implementation in amdgpu nowadays.
>>>>
>>>> [How]
>>>> Revert this patch first. After addressing all regression problems caused by
>>>> this previous patch, will add it back and adjust it.
>>>
>>> Has there been any progress on this revert, or on fixing the underlying
>>> problem ?
>>>
>>> Thanks,
>>> Guenter
>>
>> Hi Guenter,
>>
>> Wayne is OOO for CNY, but let me update you.
>>
>> Harry has sent out this series which is a collection of proper fixes.
>> https://patchwork.freedesktop.org/series/113125/
>>
>> Once that's reviewed and accepted, 4 of them are applicable for 6.1.
> 
> Any hint on when those will be reviewed and accepted?  patchwork doesn't
> show any activity on them, or at least I can't figure it out...

These patches have already made it into amd-staging-drm-next and as of
https://lore.kernel.org/amd-gfx/20230125220153.320248-1-alexander.deucher@amd.com/
they should land in drm-next soon if they haven't already.

> 
> thanks,
> 
> greg k-h

-- 
Hamza



More information about the dri-devel mailing list