[PATCH v2 4/6] drm/ttm: stop allocating dummy resources during BO creation

Das, Nirmoy nirmoy.das at linux.intel.com
Mon Jan 30 12:13:20 UTC 2023


On 1/30/2023 1:06 PM, Matthew Auld wrote:
> From: Christian König <christian.koenig at amd.com>
>
> That should not be necessary any more when drivers should at least be
> able to handle the move without a resource.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Acked-by: Nirmoy Das <nirmoy.das at intel.com>
> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 773080f48864..169818b32be2 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -952,7 +952,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
>   			 struct sg_table *sg, struct dma_resv *resv,
>   			 void (*destroy) (struct ttm_buffer_object *))
>   {
> -	static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM };
>   	int ret;
>   
>   	kref_init(&bo->kref);
> @@ -969,12 +968,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
>   		bo->base.resv = &bo->base._resv;
>   	atomic_inc(&ttm_glob.bo_count);
>   
> -	ret = ttm_resource_alloc(bo, &sys_mem, &bo->resource);
> -	if (unlikely(ret)) {
> -		ttm_bo_put(bo);
> -		return ret;
> -	}
> -
>   	/*
>   	 * For ttm_bo_type_device buffers, allocate
>   	 * address space from the device.


More information about the dri-devel mailing list