[RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

Christian König christian.koenig at amd.com
Tue Jul 4 06:57:54 UTC 2023


Am 04.07.23 um 08:50 schrieb Mauro Carvalho Chehab:
> On Mon, 3 Jul 2023 13:21:43 +0200
> Christian König <christian.koenig at amd.com> wrote:
>
>>> +	/* We don't need this BO later, release it */
>>> +	ttm_bo_put(bo);
>> That won't work. A BO must always outlive the TT object allocated for it.
>>
>> Otherwise you can get crashes during TT release.
> Just my two cents: shouldn't the TT object be increasing Kobj refcount then,
> in order to properly manage the BO object lifetime?

No, because you then get a circle reference.

The TT object is usually destroyed when the BO which is referencing it 
is destroyed.

Regards,
Christian.

>
> Regards,
> Mauro



More information about the dri-devel mailing list