[PATCH] drm/nouveau/flcn/msgq: Move assignment outside if condition

sunran001 at 208suo.com sunran001 at 208suo.com
Tue Jul 11 03:39:03 UTC 2023


Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001 at 208suo.com>
---
  drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c 
b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
index 16b246fda666..52af200b45bc 100644
--- a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
+++ b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
@@ -203,7 +203,8 @@ nvkm_falcon_msgq_new(struct nvkm_falcon_qmgr *qmgr, 
const char *name,
  {
      struct nvkm_falcon_msgq *msgq = *pmsgq;

-    if (!(msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL)))
+    msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL);
+    if (!msgq)
          return -ENOMEM;

      msgq->qmgr = qmgr;


More information about the dri-devel mailing list