[PATCH] drm/virtio: remove some redundant code
Su Hui
suhui at nfschina.com
Wed Jul 12 01:18:42 UTC 2023
On 2023/7/11 19:13, Dan Carpenter wrote:
> On Tue, Jul 11, 2023 at 05:00:31PM +0800, Su Hui wrote:
>> virtio_gpu_get_vbuf always be successful,
>> so remove the error judgment.
>>
> No, just ignore the static checker false positive in this case. The
> intent of the code is clear that if it did have an error it should
> return an error pointer.
Hi, Dan,
Function "virtio_gpu_get_vbuf" call "kmem_cache_zalloc (vgdev->vbufs,
GFP_KERNEL | __GFP_NOFAIL)" to
allocate memory. Adding the " __GFP_NOFAIL”flag make sure it won't fail.
And "virtio_gpu_get_vbuf" never
return an error code, so I think this is not a false positive.
Su Hui
>
> regards,
> dan carpenter
>
More information about the dri-devel
mailing list