[RFC PATCH 3/3] drm/file: drop DRM_MINOR_CONTROL

Simon Ser contact at emersion.fr
Fri Jul 14 10:46:06 UTC 2023


This entry should never be used by the kernel. Record the historical
context in a comment.

Signed-off-by: Simon Ser <contact at emersion.fr>
Cc: Christian König <christian.koenig at amd.com>
Cc: James Zhu <James.Zhu at amd.com>
Cc: Marek Olšák <marek.olsak at amd.com>
Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 include/drm/drm_file.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 010239392adf..a23cc2f6163f 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -53,12 +53,14 @@ struct file;
 /* Note that the values of this enum are ABI (it determines
  * /dev/dri/renderD* numbers).
  *
+ * There used to be a DRM_MINOR_CONTROL = 1 entry, but such nodes were never
+ * exposed. Still, some user-space has logic to handle them.
+ *
  * Setting DRM_MINOR_ACCEL to 32 gives enough space for more drm minors to
  * be implemented before we hit any future
  */
 enum drm_minor_type {
 	DRM_MINOR_PRIMARY = 0,
-	DRM_MINOR_CONTROL = 1,
 	DRM_MINOR_RENDER = 2,
 	DRM_MINOR_ACCEL = 32,
 };
-- 
2.41.0




More information about the dri-devel mailing list