[PATCH v4 20/21] config TEST_DYNAMIC_DEBUG default m

jim.cromie at gmail.com jim.cromie at gmail.com
Fri Jul 14 17:26:07 UTC 2023


On Thu, Jul 13, 2023 at 1:04 PM Randy Dunlap <rdunlap at infradead.org> wrote:
>
> Hi Jim,
>
> On 7/13/23 09:36, Jim Cromie wrote:
> > Signed-off-by: Jim Cromie <jim.cromie at gmail.com>
> > ---
> >  lib/Kconfig.debug | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index d4fbbcc395d2..82d11ac63758 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -2696,13 +2696,14 @@ config TEST_STATIC_KEYS
> >
> >  config TEST_DYNAMIC_DEBUG
> >       tristate "Build test-dynamic-debug module"
> > +     default m
>
> You need to justify such a change, and since it's not required
> for running the system, I don't think it should be 'm'.
>

meh, now I cant "justify" the bored/curious comment. ;-)
I'll drop this patch.

> >       depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE
> >       help
> >         This module works/demo's the dyndbg's classmap API, by
> >         creating 2 classes: a DISJOINT classmap (like DRM.debug)
> >         and a LEVELS/VERBOSE classmap (where 2>1).
> >
> > -       If unsure, say N.
> > +       If unsure, say N.  If bored/curious, say M
> >
> >  config TEST_KMOD
> >       tristate "kmod stress tester"
>
> --
> ~Randy


More information about the dri-devel mailing list