[PATCH] drm: loongson: Add a check for lsdc_bo_create() errors

[suijingfeng]

Hi,


Thanks for the patch.


The commit title generally should be 'drm/looongson: Add a check for 
lsdc_bo_create() errors'

not 'drm: loongson: xxxx'


On 2023/7/18 15:01, Dan Carpenter wrote:
> The lsdc_bo_create() function can fail so add a check for that.
>
> Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller")

Please drop this Fixes tag,  because you patch just add a error handling.

Yes,  the lsdc_bo_create() function can fail, but this is generally not 
happen.

Even if the fail happened,  your patch is not fixing the root problem.


I know that you create this patch with the bare brain,

I would like hear more practical usage or bugs of this driver.

And mention more in the commit message is preferred.


> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
> ---
>   drivers/gpu/drm/loongson/lsdc_ttm.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson/lsdc_ttm.c
> index bb0c8fd43a75..bf79dc55afa4 100644
> --- a/drivers/gpu/drm/loongson/lsdc_ttm.c
> +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c
> @@ -496,6 +496,8 @@ struct lsdc_bo *lsdc_bo_create_kernel_pinned(struct drm_device *ddev,
>   	int ret;
>   
>   	lbo = lsdc_bo_create(ddev, domain, size, true, NULL, NULL);
> +	if (IS_ERR(lbo))
> +		return ERR_CAST(lbo);
>   
>   	ret = lsdc_bo_reserve(lbo);
>   	if (unlikely(ret)) {