[PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs

[Dmitry Baryshkov]

On 27/07/2023 15:21, Rohit Agarwal wrote:
> 
> On 7/27/2023 5:15 PM, Krzysztof Kozlowski wrote:
>> On 27/07/2023 13:19, Rohit Agarwal wrote:
>>> On 7/27/2023 4:46 PM, Rob Herring wrote:
>>>> On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote:
>>>>> Update the RPMHPD references with new bindings defined in rpmhpd.h
>>>>> for Qualcomm SoCs SM8[2345]50.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar at quicinc.com>
>>>>> ---
>>>>>    
>>>>> Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml   | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml  | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml    | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml   | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml  | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml   | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/clock/qcom,videocc.yaml         | 
>>>>> 4 ++--
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml          | 
>>>>> 4 ++--
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml         | 
>>>>> 8 ++++----
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml          | 
>>>>> 4 ++--
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml         | 
>>>>> 6 +++---
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml          | 
>>>>> 4 ++--
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml         | 
>>>>> 8 ++++----
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml          | 
>>>>> 4 ++--
>>>>>    
>>>>> .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml         | 
>>>>> 8 ++++----
>>>>>    
>>>>> Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml    | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml              | 
>>>>> 4 ++--
>>>>>    
>>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 
>>>>> 6 +++---
>>>>>    18 files changed, 44 insertions(+), 44 deletions(-)
>>>>>
>>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>>
>>>> yamllint warnings/errors:
>>>>
>>>> dtschema/dtc warnings/errors:
>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory
>>>>      21 |         #include <dt-bindings/power/qcom,rpmhpd.h>
>>>>         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> compilation terminated.
>>>> make[2]: *** [scripts/Makefile.lib:419: 
>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1
>>>> make[2]: *** Waiting for unfinished jobs....
>>>> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: 
>>>> dt_binding_check] Error 2
>>>> make: *** [Makefile:234: __sub-make] Error 2
>>>>
>>>> doc reference errors (make refcheckdocs):
>>>>
>>>> See 
>>>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohiagar@quicinc.com
>>>>
>>>> The base for the series is generally the latest rc1. A different 
>>>> dependency
>>>> should be noted in *this* patch.
>>>>
>>>> If you already ran 'make dt_binding_check' and didn't see the above
>>>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>>>> date:
>>>>
>>>> pip3 install dtschema --upgrade
>>>>
>>>> Please check and re-submit after running the above command yourself. 
>>>> Note
>>>> that DT_SCHEMA_FILES can be set to your schema file to speed up 
>>>> checking
>>>> your schema. However, it must be unset to test all examples with 
>>>> your schema.
>>> This should be ignored as the patch that creates the new header is
>>> already applied.
>>> Please follow this series
>>>
>>> https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohiagar@quicinc.com/
>> Please mention the dependency in patch changelog ---, so it is obvious
>> for people applying it and also for the bot.
> Sure. Will send a cover letter for this patch mentioning the changelogs 
> and will
> keep the version as v2 since there no change at all in the patch.

What would be the merge strategy? Even if you split it per subsystem, I 
probably can not pick up display parts. Is there an immutable branch 
with the new header? Otherwise I can either ack Bjorn picking up this 
patch or it will have to wait for the next cycle.

> 
> Thanks,
> Rohit.
>> Best regards,
>> Krzysztof
>>

-- 
With best wishes
Dmitry