[PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig

[Arthur Grillo Queiroz Cabral]

On 27/07/23 05:33, Arnd Bergmann wrote:
> On Thu, Jul 27, 2023, at 00:03, Arthur Grillo wrote:
>> Using the `kunit_tool` with the command:
>>
>> tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests/
>>
>> Lead to this error[0]. Fix it by expliciting removing the
>> CONFIG_DRM_FBDEV_EMULATION.
>>
>> [0]
>> ERROR:root:
>> WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
>>   Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y]
>>   Selected by [y]:
>>   - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]
>>
> 
> I think that's a bug in the Kconfig files that should be fixed
> by enforcing the correct set of dependencies. I have not encountered

Agree, I also didn't find the error on the dependencies, so I made this
patch to see what you guys thought. Maybe Javier's take is the correct
fix.

~Arthur Grillo

> this in my randconfig builds (with a lot of other fixes applied)
> 
> In linux-next, CONFIG_VT cannot be disabled if CONFIG_EXPERT=n,
> so this does not happen.
> 
>> diff --git a/drivers/gpu/drm/tests/.kunitconfig 
>> b/drivers/gpu/drm/tests/.kunitconfig
>> index 6ec04b4c979d..c50b5a12faae 100644
>> --- a/drivers/gpu/drm/tests/.kunitconfig
>> +++ b/drivers/gpu/drm/tests/.kunitconfig
>> @@ -1,3 +1,4 @@
>>  CONFIG_KUNIT=y
>>  CONFIG_DRM=y
>>  CONFIG_DRM_KUNIT_TEST=y
>> +CONFIG_DRM_FBDEV_EMULATION=n
>>
>> base-commit: 45b58669e532bcdfd6e1593488d1f23eabd55428
> 
> Changing the local config should not be required after fixing
> the Kconfig files.
> 
>     Arnd