[PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig

[Javier Martinez Canillas]

Arthur Grillo Queiroz Cabral <arthurgrillo at riseup.net> writes:

Hello Arthur,

> On 27/07/23 13:07, Javier Martinez Canillas wrote:
>> "Arnd Bergmann" <arnd at arndb.de> writes:
>> 

[...]

>>> Changing the local config should not be required after fixing
>>> the Kconfig files.
>>>
>> 
>> CONFIG_VT can only be disabled if CONFIG_EXPERT=y but I also see that it
>> does not default to 'y' if !UML. Also FRAMEBUFFER_CONSOLE depends on !UML
>> but DRM_FBDEV_EMULATION selects FRAMEBUFFER_CONSOLE if !EXPERT.
>> 
>> Maybe we should include !UML in that condition to? Something like this:
>> 
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index 0d499669d653..734332f222ea 100644
>> --- a/drivers/gpu/drm/Kconfig
>> +++ b/drivers/gpu/drm/Kconfig
>> @@ -135,7 +135,7 @@ config DRM_DEBUG_MODESET_LOCK
>>  config DRM_FBDEV_EMULATION
>>         bool "Enable legacy fbdev support for your modesetting driver"
>>         depends on DRM
>> -       select FRAMEBUFFER_CONSOLE if !EXPERT
>> +       select FRAMEBUFFER_CONSOLE if (!EXPERT && !UML)
>>         select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
>>         default y
>>         help
>> 
>> 
>> With that I'm able to run the DRM kunit tests wihtout the mentioned
>> problem. But I'm not sure if that is the correct fix or not.
>
> It works here too, I just don't understand why this commit caused this
> bug, as it did not touch this line.

Yes, I also don't understand why the FB_CORE split made it more likely to
happen since AFAICT the same problem could had happen with just CONFIG_FB.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat