[PATCH v2 07/13] drm/msm/dpu: drop unused dpu_plane::lock

Jessica Zhang quic_jesszhan at quicinc.com
Sat Jul 29 01:10:30 UTC 2023



On 7/7/2023 4:12 PM, Dmitry Baryshkov wrote:
> The field dpu_plane::lock was never used for protecting any kind of
> data. Drop it now.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

Reviewed-by: Jessica Zhang <quic_jesszhan at quicinc.com>

> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index c2aaaded07ed..aba5185e1d66 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -78,8 +78,6 @@ static const uint32_t qcom_compressed_supported_formats[] = {
>   struct dpu_plane {
>   	struct drm_plane base;
>   
> -	struct mutex lock;
> -
>   	enum dpu_sspp pipe;
>   
>   	uint32_t color_fill;
> @@ -1186,8 +1184,6 @@ static void dpu_plane_destroy(struct drm_plane *plane)
>   		if (pstate->r_pipe.sspp)
>   			_dpu_plane_set_qos_ctrl(plane, &pstate->r_pipe, false);
>   
> -		mutex_destroy(&pdpu->lock);
> -
>   		/* this will destroy the states as well */
>   		drm_plane_cleanup(plane);
>   
> @@ -1447,8 +1443,6 @@ struct drm_plane *dpu_plane_init(struct drm_device *dev,
>   	/* success! finalize initialization */
>   	drm_plane_helper_add(plane, &dpu_plane_helper_funcs);
>   
> -	mutex_init(&pdpu->lock);
> -
>   	DPU_DEBUG("%s created for pipe:%u id:%u\n", plane->name,
>   					pipe, plane->base.id);
>   	return plane;
> -- 
> 2.39.2
> 


More information about the dri-devel mailing list