[PATCH 2/2] drm: lcdif: force modeset when FB format changes

Ying Liu gnuiyl at gmail.com
Thu Jun 1 06:24:29 UTC 2023


On Thu, Jun 1, 2023 at 2:45 AM Lucas Stach <l.stach at pengutronix.de> wrote:
>
> Force a modeset if the new FB has a different format than the
> currently active one. While it might be possible to change between
> compatible formats without a full modeset as the format control is
> also supposed to be double buffered, the colorspace conversion is
> not, so when the CSC changes we need a modeset.
>
> For now just always force a modeset when the FB format changes to
> properly reconfigure all parts of the device for the new format.
>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
> ---
>  drivers/gpu/drm/mxsfb/lcdif_kms.c | 26 ++++++++++++++++++++------
>  1 file changed, 20 insertions(+), 6 deletions(-)

LGTM. If the patch shows up in dri-devel patchwork, I can get it, test
it and provide my R-b tag if appropriate.

Regards,
Liu Ying


More information about the dri-devel mailing list