[PATCH 2/2] accel/ivpu: Do not use mutex_lock_interruptible

Jeffrey Hugo quic_jhugo at quicinc.com
Fri Jun 2 17:30:31 UTC 2023


On 5/25/2023 4:38 AM, Stanislaw Gruszka wrote:
> If we get signal when waiting for the mmu->lock we do not invalidate
> current MMU configuration what might result on undefined behavior.

"that might result in"

> Additionally there is little or no benefit on break waiting for
> ipc->lock. In current code base, we keep this lock for short periods.

What about error cases?  Nothing where say the hardware can be 
unresponsive and a process from userspace is blocked?  Without 
interruptible(), ctrl+c will have no effect.

> Fixes: 263b2ba5fc93 ("accel/ivpu: Add Intel VPU MMU support")
> Reviewed-by: Krystian Pradzynski <krystian.pradzynski at linux.intel.com>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>


More information about the dri-devel mailing list