[PATCH 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values
Javier Martinez Canillas
javierm at redhat.com
Mon Jun 5 10:15:32 UTC 2023
Maxime Ripard <mripard at kernel.org> writes:
Hello Maxime,
Thanks for your feedback.
> Hi,
>
> On Mon, Jun 05, 2023 at 09:47:50AM +0200, Javier Martinez Canillas wrote:
[...]
>> solomon,width:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> - default: 96
>> description:
>> - Width in pixel of the screen driven by the controller
>> + Width in pixel of the screen driven by the controller.
>> + The default value is controller-dependent.
>
> I think we should document it still, either in the comment itself, or
> through a conditional and different default values based on the
> compatible.
>
Makes sense. I'll add that in v2.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
More information about the dri-devel
mailing list